Skip to content

CPLAT-4887: propTypes in Component2#317

Merged
rmconsole3-wf merged 25 commits into3.1.0-wipfrom
CPLAT-4887-PropTypes
Aug 2, 2019
Merged

CPLAT-4887: propTypes in Component2#317
rmconsole3-wf merged 25 commits into3.1.0-wipfrom
CPLAT-4887-PropTypes

Conversation

@kealjones-wk
Copy link
Contributor

@kealjones-wk kealjones-wk commented Jul 5, 2019

Depends on Workiva/react-dart#192

Until @greglittlefield-wf's new adapter changes, so diff will be a little dirty until thats merged.

Motivation

Add propTypes compatibility to Component2 to include Typed props arguments.

Changes

  • Added jsifyPropTypes implementation to the component bridge.
  • Added automatic prop checks for props with @required annotations
  • Updated validateProps & validateRequiredProps to throw UnsupportedError and added mustCallSuper
  • Added Tests

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

greglittlefield-wf and others added 5 commits June 13, 2019 13:29
* master:
  Changelog entry for v2.4.4
  over_react_2.4.4+dart2
  Update base image to Dart2.4
  Add dev_dep on build_resolvers.
  Remove coverage dep as it is currently unused.
  Upgrade to analyzer 0.36.x and build_web_compilers 2.x
  Changelog entry for v2.4.3
  over_react_2.4.3+dart2
  Run CI on the dev channel as well.
  Add more detailed warning message
  Fix another typo
  Fix typo
  Warn consumers if part directive is present, but no generations were found
  Update handler chain util tests.
  Reduce callback constant boilerplate
  Add explicit dynamic return types, use new typedef syntax
  Use local methods for better stack traces, add return type to fix lints
  Remove duplicated doc comments, which get inherited
  Remove CallbackUtil generic parameter, use covariant to add chainFromList typing
* 3.1.0-wip:
  merge master and revert pubspec
  Update comments
  Update comments
  Revert "Revert "Revert pubspec""
  Revert "Revert pubspec"
  Revert pubspec
  Update pubspec
  Update copyright comments
  Update pubspec to see if CPLAT-4652 build passes
  Update pubspec
  Add pointer event callbacks to prop mixins
  Update formatting
  Remove componentFactory argument
  Update comments
  Update based on reviewer feedback
  Remove build_daemon
  Add tests
  Pull fragment from react.dart
  Add dependency to pubspec
  Add initial wrapper
@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

greglittlefield-wf and others added 6 commits July 8, 2019 17:08
* 3.1.0-wip:
  remove covariant
  adding component factory setter and updating test
  adding covariant to componentFactory
  using a field in UiProps instead of getter/setter
  re-add comment for getter
  add componentFactory setter to builder
@kealjones-wk kealjones-wk added the Hold Hold merges label Jul 15, 2019
@kealjones-wk kealjones-wk marked this pull request as ready for review July 16, 2019 18:01
@kealjones-wk kealjones-wk force-pushed the CPLAT-4887-PropTypes branch from 23c5815 to 1ecf5ba Compare July 17, 2019 18:06
@greglittlefield-wf
Copy link
Contributor

+10, besides dependency override that should be removed

Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@Workiva/release-management-p

@kealjones-wk
Copy link
Contributor Author

+1 to gregs commits :|

@kealjones-wk
Copy link
Contributor Author

@Workiva/release-management-p

@kealjones-wk kealjones-wk removed the Hold Hold merges label Aug 2, 2019
@kealjones-wk
Copy link
Contributor Author

how bout now?
@Workiva/release-management-p

@rmconsole3-wf rmconsole3-wf merged commit ca65403 into 3.1.0-wip Aug 2, 2019
@rmconsole3-wf rmconsole3-wf deleted the CPLAT-4887-PropTypes branch August 2, 2019 20:09
@aaronlademann-wf aaronlademann-wf added this to the 3.1.0 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants